WompSchmiede/FamilienFeierPlaner

SHA256

Fork 0

chore(frontend): testid fuer pending-requests-Ueberschrift in Gruppendetail #242

Merged

niboer merged 1 commit from issue-240 into main

2026-07-05 23:22:00 +02:00

niboer commented

2026-07-05 21:47:28 +02:00

Owner

closes #240

<h2> in groups/[groupId]/+page.svelte erhaelt data-testid="heading-pending-requests"
E2E-Test group-create.spec.ts verwendet testid statt Text-Selektor

closes #240 - `<h2>` in `groups/[groupId]/+page.svelte` erhaelt `data-testid="heading-pending-requests"` - E2E-Test `group-create.spec.ts` verwendet testid statt Text-Selektor

niboer added 3 commits

2026-07-05 21:47:28 +02:00

refactor(frontend): ersetze Inline-Buttons durch ActionMenu in DataTables aba4dd310c

closes #219

Aktuelles: Fuenf DataTables verwenden noch inline <Button>-Elemente in der Actions-Spalte (groups, groups/[groupId] pending requests, templates, events/[eventId] rollen, deletion-requests)

Neu: Alle fuenf Dateien nutzen <ActionMenu> mit konsistentem Pattern
- groups/+page.svelte: Bearbeiten/Loeschen via onClick
- groups/[groupId]/+page.svelte: Genehmigen/Ablehnen via type:'submit'
- templates/+page.svelte: Bearbeiten via href, Loeschen via onClick
- events/[eventId]/+page.svelte: Rollen-Bearbeiten/Loeschen via onClick
- deletion-requests/+page.svelte: Genehmigen/Ablehnen via onClick

Unit-Tests: 917 passed, Lint: OK
E2E: btn-approve-join -> action-menu-form-genehmigen

Wichtige Aenderung:
- Alte data-testid-Attribute entfallen (werden durch Auto-generierte ActionMenu-testids ersetzt)
- Nur btn-approve-join wurde in E2E-Tests referenziert

fix(e2e): fehlendes action-menu-toggle vor dem Genehmigen-Klick

CI Backend / lint-backend (pull_request) Successful in 50s

Details

CI Frontend / lint-frontend (pull_request) Successful in 1m11s

Details

CI Meta / conventional-commit (pull_request) Successful in 2s

Details

E2E / e2e (pull_request) Successful in 3m22s

Details

CI Backend / test-backend (pull_request) Successful in 1m43s

Details

CI Frontend / test-frontend (pull_request) Successful in 42s

Details

3708a4b54a

refs #219

Aktuelles: E2E-Test klickt action-menu-form-genehmigen direkt an, aber der ActionMenu-Dropdown ist nicht geoeffnet -> Element nicht sichtbar -> Test timeout

Neu: Vor dem Klick auf das Formular wird zunaechst der action-menu-toggle-Button in der korrekten Zeile geklickt (Pattern konsistent zu bestehendem Mitglied-entfernen-Test)

chore(frontend): testid fuer pending-requests-Ueberschrift in Gruppendetail

CI Backend / lint-backend (pull_request) Successful in 50s

Details

CI Frontend / lint-frontend (pull_request) Successful in 1m14s

Details

CI Meta / conventional-commit (pull_request) Successful in 1s

Details

CI Backend / test-backend (pull_request) Has been cancelled

Details

CI Frontend / test-frontend (pull_request) Has been cancelled

Details

E2E / e2e (pull_request) Has been cancelled

Details

d67c250c7d

closes #240

Aktuelles: E2E-Test verwendet Text-Selektor (h2 mit hasText) fuer
'Ausstehende Beitrittsanfragen' -> sprachanfaellig

Neu: h2 erhaelt data-testid='heading-pending-requests',
E2E-Test verwendet testid statt Text-Selektor

niboer force-pushed issue-240 from d67c250c7d

CI Backend / lint-backend (pull_request) Successful in 50s

Details

CI Frontend / lint-frontend (pull_request) Successful in 1m14s

Details

CI Meta / conventional-commit (pull_request) Successful in 1s

Details

CI Backend / test-backend (pull_request) Has been cancelled

Details

CI Frontend / test-frontend (pull_request) Has been cancelled

Details

E2E / e2e (pull_request) Has been cancelled